linux-kernel - Re: [PATCH 0/2] fix gpio-keys debouncing and timer sleep issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1246271548.20530.207.camel@jani-desktop>
Date:	Mon, 29 Jun 2009 13:32:28 +0300
From:	Jani Nikula <ext-jani.1.nikula@...ia.com>
To:	ext Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	"alek.du@...el.com" <alek.du@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"soni.trilok@...il.com" <soni.trilok@...il.com>,
	"ben-linux@...ff.org" <ben-linux@...ff.org>,
	"Carmody Phil.2 (EXT-Ixonos/Helsinki)" <ext-phil.2.carmody@...ia.com>
Subject: Re: [PATCH 0/2] fix gpio-keys debouncing and timer sleep issues

On Mon, 2009-06-29 at 07:59 +0200, ext Dmitry Torokhov wrote:
> I intend to apply the both patches. It is unfortunate that we need to
> use both a timer and a workqueue, I wonder what would it take to
> implement something like reschedule_delayed_work() that would adjust
> the delay in the same fashion that mod_timer() does?

Hi Dmitry -

Since a delayed_work is simply a work_struct and a timer_list, the only
overhead here is the one line timer function. A work_struct per button
is of course an addition to the original in both Alek's patch and mine,
but I guess there are no alternatives if gpio_get_value may sleep.

I did think about something like reschedule_delayed_work myself, but
tackling the locking issues seemed like too much work compared to this
simple solution.


BR,
Jani.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/