linux-kernel - Re: [PATCH] tracing/syscall: remove redundant code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090629111334.GA6265@nowhere>
Date:	Mon, 29 Jun 2009 13:13:36 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc:	Ingo <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/syscall: remove redundant code

On Mon, Jun 29, 2009 at 05:16:23PM +0800, Xiao Guangrong wrote:
> No need to call trace_wake_up() explicitly because it's called
> in trace_current_buffer_unlock_commit().
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
> ---
>  kernel/trace/trace_syscalls.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c
> index 5e57964..dd1ce2c 100644
> --- a/kernel/trace/trace_syscalls.c
> +++ b/kernel/trace/trace_syscalls.c
> @@ -168,7 +168,6 @@ void ftrace_syscall_enter(struct pt_regs *regs)
>  	syscall_get_arguments(current, regs, 0, sys_data->nb_args, entry->args);
>  
>  	trace_current_buffer_unlock_commit(event, 0, 0);
> -	trace_wake_up();
>  }
>  
>  void ftrace_syscall_exit(struct pt_regs *regs)
> @@ -194,7 +193,6 @@ void ftrace_syscall_exit(struct pt_regs *regs)
>  	entry->ret = syscall_get_return_value(current, regs);
>  
>  	trace_current_buffer_unlock_commit(event, 0, 0);
> -	trace_wake_up();
>  }
>  
>  static int init_syscall_tracer(struct trace_array *tr)
> -- 
> 1.6.1.2
> 

Thanks,

Acked-by: Frederic Weisbecker <fweisbec@...il.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/