linux-kernel - Re: [GIT PULL] notification tree - fsnotify assumes incorrectly positive parent dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2009 13:09:09 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Eric Paris <eparis@...hat.com>
cc:	Al Viro <viro@...iv.linux.org.uk>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Jeremy Kerr <jk@...abs.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] notification tree - fsnotify assumes incorrectly
 positive parent dentry



On Mon, 29 Jun 2009, Eric Paris wrote:
>
> Linus please consider pulling from the notification tree.  There is one
> patch in the tree which should fix an issue in which fsnotify assumed
> that dentry->d_parent->d_inode != NULL.  This turns out to be false for
> spufs and causes a panic.

Hmm. It does sound like a reasonable assumption, though. Maybe spufs 
should be fixed to have an inode for all directories?

A NULL d_inode means that something is a negative dentry, and a negative 
dentry shouldn't have children.

Added a few ppc people to the cc.

I'll pull the fix, but I really think it sounds like spufs is doing 
something wrong here.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/