linux-kernel - Re: MFD: mutex from ISR in ezx-pcap?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246352256.18231.408.camel@brutus>
Date:	Tue, 30 Jun 2009 05:57:36 -0300
From:	Daniel Ribeiro <drwyrm@...il.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	sameo@...ux.intel.com, LKML <linux-kernel@...r.kernel.org>,
	laforge@...nezx.org
Subject: Re: MFD: mutex from ISR in ezx-pcap?

Em Ter, 2009-06-30 às 00:11 +0200, Jiri Slaby escreveu: 
> > pcap_adc_irq actually already runs from a workqueue (pcap_isr_work).
> 
> Aha, thanks, there is a specific irq handler. Ok, sounds fair.
> 
> But interrupts are disabled in pcap_isr_work anyway,

Right.

> so that
> pcap_adc_irq shouldn't sleep, right? Or maybe I missed something again...

No. Interrupts are enabled again before pcap_adc_irq() runs.

pcap_isr_work() doesn't call pcap_adc_irq directly, it calls the
irq_flow_handler, handle_simple_irq(), which needs to run with
interrupts disabled. Interrupts are enabled again on handle_IRQ_event(),
as pcap_adc_irq is requested _without_ IRQF_DISABLED.

-- 
Daniel Ribeiro

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)