linux-kernel - [RESEND Patch] kcore: remove its pointless size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090630100850.GD5873@cr0.nay.redhat.com>
Date:	Tue, 30 Jun 2009 18:08:50 +0800
From:	Amerigo Wang <xiyou.wangcong@...il.com>
To:	Amerigo Wang <xiyou.wangcong@...il.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Tao Ma <tao.ma@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Alexey Dobriyan <adobriyan@...il.com>, mtk.manpages@...il.com
Subject: [RESEND Patch] kcore: remove its pointless size


Linus fixes wrong size of /proc/kcore problem in commit 9063c61fd5cbd.

But its size still looks insane, since it never equals to the size
of physical memory.

Signed-off-by: WANG Cong <amwang@...hat.com>
Cc: mtk.manpages@...il.com

(Andrew, could you please just cut off the kernel part from below? :)

---
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index 59b43a0..eca5201 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -405,9 +405,6 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos)
 static int __init proc_kcore_init(void)
 {
 	proc_root_kcore = proc_create("kcore", S_IRUSR, NULL, &proc_kcore_operations);
-	if (proc_root_kcore)
-		proc_root_kcore->size =
-				(size_t)high_memory - PAGE_OFFSET + PAGE_SIZE;
 	return 0;
 }
 module_init(proc_kcore_init);



---
diff --git a/man5/proc.5 b/man5/proc.5
index ed47f70..e31aae4 100644
--- a/man5/proc.5
+++ b/man5/proc.5
@@ -1246,8 +1246,6 @@ kernel
 binary, GDB can be used to
 examine the current state of any kernel data structures.
 
-The total length of the file is the size of physical memory (RAM) plus
-4KB.
 .TP
 .I /proc/kmsg
 This file can be used instead of the
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/