linux-kernel - Re: [PATCH 0/3] msm_sdcc: A few more cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246365021.10129.146.camel@Joe-Laptop.home>
Date:	Tue, 30 Jun 2009 05:30:21 -0700
From:	Joe Perches <joe@...ches.com>
To:	Pavel Machek <pavel@....cz>
Cc:	linux-kernel@...r.kernel.org, pierre@...man.eu,
	swetland@...gle.com, Andrew Morton <akpm@...ux-foundation.org>,
	San Mehat <san@...gle.com>
Subject: Re: [PATCH 0/3] msm_sdcc: A few more cleanups

On Tue, 2009-06-30 at 08:57 +0200, Pavel Machek wrote:
> diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
> -	do_div(clks, NSECS_PER_SEC);
> +	do_div(clks, NSEC_PER_SEC);

Compiling is good.  Submitting uncompiled patches not so good...

> @@ -588,6 +588,8 @@ static void
>  msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data,
>  			u32 status)
>  {
> +	void __iomem	*base = host->base;
> +

I don't know how performance sensitive this is.

Maybe it should be inline and have base passed
as an argument.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/