linux-kernel - Re: [patch] x86: fix arch/x86/lib/clear_page_64.S::clear_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246366820.6538.1.camel@marge.simson.net>
Date:	Tue, 30 Jun 2009 15:00:20 +0200
From:	Mike Galbraith <efault@....de>
To:	Alexander van Heukelum <heukelum@...tmail.fm>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Cyrill Gorcunov <gorcunov@...il.com>
Subject: Re: [patch] x86: fix arch/x86/lib/clear_page_64.S::clear_page_c
 annotation

On Tue, 2009-06-30 at 13:42 +0200, Alexander van Heukelum wrote:
> Hi Mike,
> 
> I agree with the code, but I do have a remark...
> 
> The ENTRY() macro already includes the ALIGN, so you could get
> rid of the preceding ALIGN. But it's just a neatness thing, because
> two consecutive ALIGNS don't change the resulting binary.
> 
> At any rate:
> 
> Acked-by: Alexander van Heukelum <heukelum@...tmail.fm>
> 
> (maybe the x86-committer feels comfortable enough to remove the ALIGN ;)
> )

No doubt, but I can save him the trouble ;-)

x86: fix incorrect arch/x86/lib/clear_page_64.S::clear_page_c annotation.

Signed-off-by: Mike Galbraith <efault@....de>
Acked-by: Alexander van Heukelum <heukelum@...tmail.fm>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Cyrill Gorcunov <gorcunov@...il.com>
LKML-Reference: <new-submission>

---
 arch/x86/lib/clear_page_64.S |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6/arch/x86/lib/clear_page_64.S
===================================================================
--- linux-2.6.orig/arch/x86/lib/clear_page_64.S
+++ linux-2.6/arch/x86/lib/clear_page_64.S
@@ -5,15 +5,14 @@
  * Zero a page. 	
  * rdi	page
  */			
-	ALIGN
-clear_page_c:
+ENTRY(clear_page_c)
 	CFI_STARTPROC
 	movl $4096/8,%ecx
 	xorl %eax,%eax
 	rep stosq
 	ret
 	CFI_ENDPROC
-ENDPROC(clear_page)
+ENDPROC(clear_page_c)
 
 ENTRY(clear_page)
 	CFI_STARTPROC


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/