linux-kernel - Re: [PATCH] powerpc: Fix spin_event_timeout() to be robust over context switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ed82fe3e0906300802h2bcfb651q5f8a37423307e7ff@mail.gmail.com>
Date:	Tue, 30 Jun 2009 10:02:49 -0500
From:	Timur Tabi <timur@...escale.com>
To:	Grant Likely <grant.likely@...retlab.ca>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	jonsmirl@...il.com
Subject: Re: [PATCH] powerpc: Fix spin_event_timeout() to be robust over 
	context switches

On Mon, Jun 29, 2009 at 6:40 PM, Grant Likely<grant.likely@...retlab.ca> wrote:
> From: Grant Likely <grant.likely@...retlab.ca>
>
> Current implementation of spin_event_timeout can be interrupted by an
> IRQ or context switch after testing the condition, but before checking
> the timeout.  This can cause the loop to report a timeout when the
> condition actually became true in the middle.
>
> This patch adds one final check of the condition upon exit of the loop
> if the last test of the condition was still false.
>
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>

Acked-by: Timur Tabi <timur@...escale.com>

Ben, please pick this up for the next rc of 2.6.31.

-- 
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/