linux-kernel - RE: [PATCH v1 6/6][ARM] new ARM SoC support: BCMRing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8628FE4E7912BF47A96AE7DD7BAC0AADCB25AE1BA7@SJEXCHCCR02.corp.ad.broadcom.com>
Date:	Tue, 30 Jun 2009 16:54:50 -0700
From:	"Leo (Hao) Chen" <leochen@...adcom.com>
To:	"Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@...osoft.com>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>
cc:	"linux-arm-kernel@...ts.arm.linux.org.uk" 
	<linux-arm-kernel@...ts.arm.linux.org.uk>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>,
	"Leo (Hao) Chen" <leochen@...adcom.com>
Subject: RE: [PATCH v1 6/6][ARM]  new ARM SoC support: BCMRing


 

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@...osoft.com] 
> Sent: Tuesday, June 30, 2009 4:38 PM
> To: Alan Cox
> Cc: Leo (Hao) Chen; linux-arm-kernel@...ts.arm.linux.org.uk; 
> Linux Kernel
> Subject: Re: [PATCH v1 6/6][ARM] new ARM SoC support: BCMRing
> 
> On 00:20 Wed 01 Jul     , Alan Cox wrote:
> > On Tue, 30 Jun 2009 20:41:01 +0200
> > Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> wrote:
> > 
> > > On 16:30 Fri 26 Jun     , Leo (Hao) Chen wrote:
> > > > Hi,
> > > > 
> > > > The last patch. This big patch includes the minimal set 
> of our CSP (chip support package), which is our OS 
> independent chip supporting code and headers.  All the codes 
> are under arch/arm/mach-bcmring directory.
> > > This patch is unreadable
> > > you need
> > > 1) Respect the Linux coding Style
> > 
> > For an OS independant set of chip support defines that 
> usually makes no
> > sense
> here it's really unreadable
> IMHO as you will have to rewrite it to use the kernel API so 
> it make sense

I am fixing the coding style errors reported by the checkpatch.pl script. So that they should be more readable to kernel developers.

> > 
> > > 2) to split in small changeset
> > 
> > For a new submission that generally doesn't make much sense 
> either - not
> > for all the new files stuff.
> here you have mixed timer, dma, irq, clock, and other new 
> files in the same
> patch, it's really hard to follow the patch. Split it a few 
> will be easier
> to review IMHO
> 

I am trying to split the patch into smaller patches with block level code.

> Best Regards,
> J.
> 

Thanks for your input,

Leo Chen
Software Engineer
Broadcom Canada Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/