[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090630022034.5167b706@mycelium.queued.net>
Date: Tue, 30 Jun 2009 02:20:34 -0400
From: Andres Salomon <dilinger@...labora.co.uk>
To: richard@...top.org
Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>, cbou@...l.ru,
dwmw2@...radead.org, linux-kernel@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Paul Fox <pgf@...top.org>, dsaxena@...top.org
Subject: Re: [PATCH 3/5] power_supply: add a TRICKLE_CHARGING status, and
add it to the olpc driver
On Tue, 23 Jun 2009 19:13:17 -0400
"Richard A. Smith" <richard@...top.org> wrote:
> Mark Brown wrote:
>
> > The problem here is that anything which is already looking at these
> > statuses is going to have to be able to cope with the information
> > too. In the OLPC case it probably doesn't matter so much if they get
> > confused since this is an unusual case but in the embedded case it's
> > much more normal (and more likely to happen while a user interacts
> > with the device since that tends to burn power which is a problem
> > if you're charging off USB).
>
> > A separate file with the detailed information would sidestep this
> > since it's a new interface. I'm not strongly opposed to adding the
> > new states but I do think it's worth considering other ways of
> > doing this.
>
> I've got no problems with a new interface. But, i'm also not the
> person writing the driver. :)
>
> I can change my script to test for the presence of this new interface
> and use that if it exists rather easily. I already have to handle a
> few cases like that where Andres changed things when I wasn't
> watching.
>
> Suggestions on what it would look like?
>
Richard, can you please verify that you're happy w/ the proposed
API in the latest bunch of patches?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists