[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87y6r9dz4h.fsf@devron.myhome.or.jp>
Date: Wed, 01 Jul 2009 09:29:34 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Marton Balint <cus@...ekas.hu>
Cc: linux-kernel@...r.kernel.org
Subject: Re: vfat creates multiple files with the same filename
Marton Balint <cus@...ekas.hu> writes:
> On Tue, 30 Jun 2009, OGAWA Hirofumi wrote:
>> Marton Balint <cus@...ekas.hu> writes:
>>
>> > I don't know if removing the invalid characters silently instead of
>> > returning EINVAL is a good practice, but allowing two files with identical
>> > filenames is definitely wrong.
>>
>> The utf8 function seems didn't return the error for invalid char.
>>
>> > Could someone please have a look at the problem? Unfortunately I am not
>> > qualified enough to track it down...
>> >
>> > I've run the testcase on both 2.6.30 and 2.6.31-rc1 kernels, but this bug
>> > is probably not very new, since I remember having it also in 2.6.27.
>>
>> This is quick hack though, this should return -EINVAL for invalid char
>> like nls. Can you try this?
>
> It works for me, filenames with invalid utf-8 characters are now rejected,
> so I no longer can create multiple files with the same name. Thanks for
> the fix.
Thanks for testing.
--
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists