linux-kernel - Re: [PATCH] gpiolib: allow exported GPIO nodes to be named using sysfs links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906301843.22646.david-b@pacbell.net>
Date:	Tue, 30 Jun 2009 18:43:22 -0700
From:	David Brownell <david-b@...bell.net>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Jani Nikula <ext-jani.1.nikula@...ia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib: allow exported GPIO nodes to be named using sysfs links

On Monday 22 June 2009, Andrew Morton wrote:
> On Thu, 11 Jun 2009 12:19:03 +0300
> Jani Nikula <ext-jani.1.nikula@...ia.com> wrote:
> 
> > +int gpio_export_link(struct device *dev, const char *name, unsigned gpio)
> > +{
> > +	struct gpio_desc	*desc;
> > +	int			status = -EINVAL;
> > +
> > +	BUG_ON(dev == NULL);
> > +	BUG_ON(name == NULL);
> 
> We usually don't bother with these assertions.  If the kernel will
> reliably oops if one of these is NULL, then that provides the same
> information anyway.

Yeah, it'd be better to remove those BUG_ON() things before this goes upstream...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/