linux-kernel - Re: [PATCH] MFD: ezx-pcap, fix lock imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090701080914.GA5840@sortiz.org>
Date:	Wed, 1 Jul 2009 10:09:17 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Daniel Ribeiro <drwyrm@...il.com>
Cc:	Jiri Slaby <jirislaby@...il.com>, laforge@...nezx.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MFD: ezx-pcap, fix lock imbalance

Hi Daniel,

On Wed, Jul 01, 2009 at 04:04:31AM -0300, Daniel Ribeiro wrote:
> Hi Jiri,
> 
> Em Qua, 2009-07-01 às 08:53 +0200, Jiri Slaby escreveu:
> > There is an omitted unlock in pcap_adc_irq ISR on one fail path. Fix that.
> > 
> > Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> 
> I would be happy to ack this, however, you are late. ;)
> 
> http://patchwork.kernel.org/patch/32002/
> 
> Samuel seems to be unreachable ATM, last email I have from him is from
> June 16. :(
Sorry for the delay, I was travelling. I'll be going through my mail backlog
today.

Cheers,
Samuel.


> > ---
> >  drivers/mfd/ezx-pcap.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
> > index 671a7ef..c1de4af 100644
> > --- a/drivers/mfd/ezx-pcap.c
> > +++ b/drivers/mfd/ezx-pcap.c
> > @@ -238,8 +238,10 @@ static irqreturn_t pcap_adc_irq(int irq, void *_pcap)
> >  	mutex_lock(&pcap->adc_mutex);
> >  	req = pcap->adc_queue[pcap->adc_head];
> >  
> > -	if (WARN(!req, KERN_WARNING "adc irq without pending request\n"))
> > +	if (WARN(!req, KERN_WARNING "adc irq without pending request\n")) {
> > +		mutex_unlock(&pcap->adc_mutex);
> >  		return IRQ_HANDLED;
> > +	}
> >  
> >  	/* read requested channels results */
> >  	ezx_pcap_read(pcap, PCAP_REG_ADC, &tmp);
> 
> -- 
> Daniel Ribeiro



-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/