linux-kernel - Re: [KVM PATCH v7 0/5] irqfd fixes and enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A4B2406.2020901@redhat.com>
Date:	Wed, 01 Jul 2009 11:53:26 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Gregory Haskins <ghaskins@...ell.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org, mst@...hat.com,
	davidel@...ilserver.org
Subject: Re: [KVM PATCH v7 0/5] irqfd fixes and enhancements

On 06/29/2009 09:28 PM, Gregory Haskins wrote:
> (Applies to kvm.git/master:4631e094)
>
> The following is the latest attempt to fix the races in irqfd/eventfd, as
> well as restore DEASSIGN support.  For more details, please read the patch
> headers.  I've restored the slow-work variant of the logic as a separate
> patch (5/5) so we can get a better idea of the true difference between
> the workqueue approach and the slow-work style.  I am personally in favor
> of the slow-work approach since it doesnt require a mostly-idle+dedicated
> thread to hang around.  But that is just me.  5/5 can be ignored, folded
> in to 3/5+4/5 as appropriate, or merged as is per the whim of Avi et. al.
>    

I think a good compromise would be to create the workqueue when the 
first VM is launched.

> As always, this series has been tested against the kvm-eventfd unit test
> with both 5/5 applied and unapplied, and everything appears to be
> functioning properly. You can download this test here:
>
> ftp://ftp.novell.com/dev/ghaskins/kvm-eventfd.tar.bz2
>
> I've included version 4 of Davide's eventfd patch (ported to kvm.git) so
> that its a complete reviewable series.  Note, however, that there may be
> later versions of his patch to consider for merging, so we should
> coordinate with him.
>    

Davide's patch was merged upstream.  Please take a look to make sure 
this patchset is compatible with what was merged.

Patchset looks good to me, but I'd appreciate an ack from Michael (or 
anyone else who's interested).

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/