linux-kernel - Re: [PATCH 3/6 -tip] perf_counter: Add Generalized Hardware vectored co-processor support for AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090701114928.GI15958@elte.hu>
Date:	Wed, 1 Jul 2009 13:49:28 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Paul Mackerras <paulus@...ba.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Anton Blanchard <anton@...ba.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 3/6 -tip] perf_counter: Add Generalized Hardware
	vectored co-processor support for AMD


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> On Wed, 2009-07-01 at 13:27 +0200, Ingo Molnar wrote:
> > * Ingo Molnar <mingo@...e.hu> wrote:
> > 
> > > >  Performance counter stats for '/usr/bin/vlc /home/jaswinder/Videos/Linus_Torvalds_interview_with_Charlie_Rose_Part_1.flv':
> > > > 
> > > >     20177177044  vec-adds                  (scaled from 66.63%)
> > > >     34101687027  vec-muls                  (scaled from 66.64%)
> > > >      3984060862  vec-divs                  (scaled from 66.71%)
> > > >     26349684710  vec-idle-cycles           (scaled from 66.65%)
> > > >      9052001905  vec-stall-cycles          (scaled from 66.66%)
> > > >     76440734242  vec-ops                   (scaled from 66.71%)
> > > > 
> > > >   272.523058097  seconds time elapsed
> > 
> > btw., the 'perf list' bits are missing - any new counter added 
> > should be listed by 'perf list' as well - otherwise people wont know 
> > what we have and what to use.
> > 
> 
> Even cache is not available for 'perf list'. Should I also resend 
> patch for adding cache along with vector and interrupt.

I'd suggest for you to send a separate patch for the cache bits 
first (that way it's not held up by other dependencies) - and keep 
the vector and irq bits in their respective patches.

I.e. when we add new generic events, we want to enable it in the 
full tool-space in a single patch.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/