linux-kernel - Re: wait_task_zombie plus WNOWAIT question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090701135544.GA24374@redhat.com>
Date:	Wed, 1 Jul 2009 15:55:44 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Vitaly Mayatskikh <v.mayatskih@...il.com>
Cc:	Roland McGrath <roland@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: wait_task_zombie plus WNOWAIT question

On 07/01, Vitaly Mayatskikh wrote:
>
> I'm working on (sigh) next version of wait_task_* cleanups and stuck
> in wait_task_zombie. I'm trying to move put_user(stat, wo->wo_stat)
> code from all wait_task_* functions to common place, but
> wait_task_zombie does not fill wo_stat if WNOWAIT flag is set

Only waitid() can use WNOWAIT, and in this case ->wo_stat == NULL.

> and does
> it w/o that flag. Is it done so by design, or I can make
> user-visible change and add put_user in WNOWAIT path?

Just check do not do put_user(->wo_stat) if it is NULL in do_wait
pathes.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/