linux-kernel - Re: [PATCH] cdc-acm: work around some broken devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0907011030130.3066-100000@iolanthe.rowland.org>
Date:	Wed, 1 Jul 2009 10:34:03 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Arseniy Lartsev <ars3n@...dex.ru>
cc:	Oliver Neukum <oliver@...kum.org>,
	USB list <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <greg@...ah.com>
Subject: Re: [PATCH] cdc-acm: work around some broken devices

On Wed, 1 Jul 2009, Arseniy Lartsev wrote:

> On Wednesday 01 July 2009 15:37:48 Oliver Neukum wrote:
> > Yes, exactly. Please add greg@...ah.com into CC, add a Signed-off-by line
> > and resend.
> ok
> 
> Signed-off-by: Arseniy Lartsev <ars3n at yandex dot ru>
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -387,6 +387,7 @@ static void acm_rx_tasklet(unsigned long
>  	struct acm_ru *rcv;
>  	unsigned long flags;
>  	unsigned char throttled;
> +	struct usb_host_endpoint *ep;
>  
>  	dbg("Entering acm_rx_tasklet");
>  
> @@ -462,11 +463,20 @@ urbs:
>  
>  		rcv->buffer = buf;
>  
> -		usb_fill_bulk_urb(rcv->urb, acm->dev,
> -				  acm->rx_endpoint,
> -				  buf->base,
> -				  acm->readsize,
> -				  acm_read_bulk, rcv);
> +		ep = (usb_pipein(acm->rx_endpoint) ? acm->dev->ep_in : acm->dev->ep_out)
> +				[usb_pipeendpoint(acm->rx_endpoint)];

Isn't acm->rx_endpoint always going to be IN?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/