linux-kernel - Re: [PATCH 1/1] i915: fix up a raw 64bit divide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090701163235.GG13837@shadowen.org>
Date:	Wed, 1 Jul 2009 17:32:35 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Dave Airlie <airlied@...ux.ie>, Eric Anholt <eric@...olt.net>,
	dri-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] i915: fix up a raw 64bit divide

On Wed, Jul 01, 2009 at 09:12:55AM -0700, Jesse Barnes wrote:
> On Wed,  1 Jul 2009 15:20:59 +0100
> Andy Whitcroft <apw@...onical.com> wrote:
> 
> > We are seeing compilation failures on i386 in some environments due
> > to an undefined reference as below:
> > 
> >     ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!
> > 
> > This is generated due to a raw 64 bit divide in the i915 driver.  Fix
> > up this raw divide.
> > 
> > Signed-off-by: Andy Whitcroft <apw@...onical.com>
> 
> I think building with newer GCCs will prevent this error, but the fix
> looks fine.

Yeah I suspect gcc interactions here, as builds on older userspace were
failing in this way but not so in the very latest karmic userspace.  I
suspect its still correct to avoid these currently.

> Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>

Thanks.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/