linux-kernel - RE: Problem with /proc/iomem on ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BD79186B4FD85F4B8E60E381CAEE190901A1383F@mi8nycmail19.Mi8.com>
Date:	Wed, 1 Jul 2009 14:01:14 -0400
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	"Kay Sievers" <kay.sievers@...y.org>
Cc:	<linux-kernel@...r.kernel.org>
Subject: RE: Problem with /proc/iomem on ARM

On Wednesday, July 01, 2009 10:55 AM, Kay Sievers wrote:
> On Wed, Jul 1, 2009 at 19:32, H Hartley wrote:
>> I just noticed a problem with /proc/iomem on my ARM system
>> that I think was introduced by your patch:
>>
>> commit 1d559e29138834bbcdf34ac072232bf543bfc4e0
>> Author: Kay Sievers <kay.sievers@...y.org>
>> Date:   Tue Jan 6 10:44:43 2009 -0800
>>
>>    arm: struct device - replace bus_id with dev_name(), dev_set_name()
>>
>>    Cc: Russell King <rmk@....linux.org.uk>
>>    Signed-off-by: Kay Sievers <kay.sievers@...y.org>
>>    Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
>
>> This was seen with kernel 2.6.30.  I havn't looked at /proc/iomem for
>> a while so I'm not sure when this first started.
>
> Are you sure, 8a577ffc75d9194fe8cdb7479236f2081c26ca1f isn't in your tree?

That commit is in my tree.  It appears that commit only fixes pci devices.
The serial ports on my system are amba bus devices.

> After all, it seems like this should be fixed in arm somewhere, not to
> copy and store internal driver core pointers, but use the device
> itself to retrieve the values.

Maybe the problem is in drivers/amba/bus.c? amba_device_register() does:

	dev->res.name = dev_name(&dev->dev);

But there is nothing in the code about setting the kobj.

Regards,
Hartley