linux-kernel - Re: [PATCH] adxl345 accelerometer hwmon driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090701221310.1d6aa587@hyperion.delvare>
Date:	Wed, 1 Jul 2009 22:13:10 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	"Chris Verges" <chrisv@...erswitching.com>
Cc:	"Jonathan Cameron" <jic23@....ac.uk>, linux-kernel@...r.kernel.org,
	lm-sensors@...sensors.org
Subject: Re: [PATCH] adxl345 accelerometer hwmon driver

On Wed, 1 Jul 2009 12:19:02 -0700, Chris Verges wrote:
> > What are you actually doing with it?  If you aren't doing hardware
> > monitoring then I would expect you aren't going to receive a
> > favourable response on here.
> 
> The ADXL345 is a 3D accelerometer.  It's very similar to the following
> chips already in the HWMON section of the kernel:
> 
>    - SENSORS_LIS3LV02D
>    - SENSORS_APPLESMC
> 
> The driver provides 3D axis data when the user polls the chip via the
> sysfsinterface.

A few accelerometer drivers were originally added to drivers/hwmon
because the chips also included some hwmon features (e.g. temperature
sensor.) Now every new accelerometer driver gets dropped in
drivers/hwmon "because there are other accelerometer drivers there".
The LIS3LV02D driver is a perfect example of this... the device is not
even registered as a hwmon driver! This driver definitely doesn't
belong there.

Probably it's about time to put an end to this and kick all
accelerometer drivers out of drivers/hwmon.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/