linux-kernel - Re: tools/perf compile error: ignoring return value of 'read', declared with attribute warn_unused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090702074419.GB19187@elte.hu>
Date:	Thu, 2 Jul 2009 09:44:19 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Kevin Winchester <kjwinchester@...il.com>,
	Frédéric Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: tools/perf compile error: ignoring return value of 'read',
	declared with attribute warn_unused_result


* Kevin Winchester <kjwinchester@...il.com> wrote:

>     CC builtin-stat.o
> cc1: warnings being treated as errors
> builtin-stat.c: In function 'run_perf_stat':
> builtin-stat.c:243: error: ignoring return value of 'read', declared with attribute warn_unused_result
> builtin-stat.c:256: error: ignoring return value of 'read', declared with attribute warn_unused_result
> make: *** [builtin-stat.o] Error 1
> 
> Apparently my version of gcc and/or glibc do not agree with -Werror.  Would the fix be as simple as:
> 
>     if *read(go_pipe[0], &buf, 1) < 0) {
>             perror("Failed to read go_pipe.");
>             exit(1);
>     }
> 
> ?

Yeah, that's Ubuntu doing some must-check-warnings via headers, 
right?

Frederic fixed a bug there yesterday - mind checking the latest 
perfcounters code at:

  http://people.redhat.com/mingo/tip.git/README

?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/