linux-kernel - Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A4CC14C.1000905@redhat.com>
Date:	Thu, 02 Jul 2009 17:16:44 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Gregory Haskins <ghaskins@...ell.com>
CC:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org, mst@...hat.com,
	davidel@...ilserver.org
Subject: Re: [KVM PATCH v8 1/3] KVM: Fix races in irqfd using new eventfd_kref_get
 interface

On 07/01/2009 07:09 PM, Gregory Haskins wrote:
> eventfd currently emits a POLLHUP wakeup on f_ops->release() to generate a
> "release" callback.  This lets eventfd clients know if the eventfd is about
> to go away and is very useful particularly for in-kernel clients.  However,
> until recently it is not possible to use this feature of eventfd in a
> race-free way.
>
> This patch utilizes a new eventfd interface to rectify the problem.  It also
> converts the eventfd POLLHUP generation code to use the locked variant
> of wakeup.
>
> Signed-off-by: Gregory Haskins<ghaskins@...ell.com>
> CC: Davide Libenzi<davidel@...ilserver.org>
> ---
>
>   fs/eventfd.c             |    7 --
>   include/linux/kvm_host.h |    5 +
>   virt/kvm/eventfd.c       |  187 ++++++++++++++++++++++++++++++++--------------
>   3 files changed, 134 insertions(+), 65 deletions(-)
>    


Please split the eventfd.c hunk into a separate patch.  When preparing 
the 2.6.32 submission, I'll fold that into the patch into its antipatch 
and they'll disappear.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/