linux-kernel - Re: Re: [PATCH] cciss: Ignore stale commands after reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090702200104.GF23611@kernel.dk>
Date:	Thu, 2 Jul 2009 22:01:04 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Miller, Mike (OS Dev)" <Mike.Miller@...com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: Re: [PATCH] cciss: Ignore stale commands after reboot

On Thu, Jul 02 2009, Miller, Mike (OS Dev) wrote:
>  
> 
> > -----Original Message-----
> > From: Andrew Morton [mailto:akpm@...ux-foundation.org] 
> > Sent: Thursday, July 02, 2009 2:51 PM
> > To: Miller, Mike (OS Dev)
> > Subject: Fw: Re: [PATCH] cciss: Ignore stale commands after reboot
> > 
> > 
> > oh, Jens already did it.
> > 
> > Begin forwarded message:
> > 
> > Date: Thu, 2 Jul 2009 21:00:49 +0200
> > From: Jens Axboe <jens.axboe@...cle.com>
> > To: Hannes Reinecke <hare@...e.de>
> > Cc: scameron@...rdog.cca.cpqcorp.net, 
> > linux-kernel@...r.kernel.org, mikem@...rdog.cca.cpqcorp.net
> > Subject: Re: [PATCH] cciss: Ignore stale commands after reboot
> > 
> > 
> > On Thu, Jul 02 2009, Hannes Reinecke wrote:
> > > 
> > > When doing an unexpected shutdown like kexec the cciss 
> > firmware might 
> > > still have some commands in flight, which it is trying to complete.
> > > The driver is doing it's best on resetting the HBA, but 
> > sadly there's 
> > > a firmware issue causing the firmware _not_ to abort or drop old 
> > > commands.
> > > So the firmware will send us commands which we haven't 
> > accounted for, 
> > > causing the driver to panic.
> > > 
> > > With this patch we're just ignoring these commands as there 
> > is nothing 
> > > we could be doing with them anyway.
> > 
> > Looks good to me. Mike, Stephen?
> 
> Sorry I haven't seen this before. The beardog addresses are no longer
> valid. We moved into a dungeon and into a new domain. The good folks
> in IT have yet to assign another IP address/domain name or an MX
> record for the mail servers. I hope that by next week that will be
> corrected. Until then all Steve and I have to use is some form of
> OutHouse mail client.
>
> Acked-by: Mike Miller <mike.miller@...com>

OK, I'll add the patch with your ack.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/