linux-kernel - Re: [PATCH] tracing: fix trace_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A4C4C2D.3040709@cn.fujitsu.com>
Date:	Thu, 02 Jul 2009 13:57:01 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Ingo Molnar <mingo@...e.hu>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: fix trace_print_seq()

>> There have a example:
>> after reboot:
>> # echo kmemtrace > current_tracer
>> # echo 0 > options/kmem_minimalistic
>> # cat trace
>> # tracer: kmemtrace
>> #
>> #
>> Nothing is exported, because the first byte of trace_seq->buffer[ ]
>> is KMEMTRACE_USER_ALLOC.
>> ( the value of KMEMTRACE_USER_ALLOC is zero, seeing
>>   kmemtrace_print_alloc_user() in kernel/trace/kmemtrace.c)
>>
...
> Looks good, thanks.
> 
> Acked-by: Frederic Weisbecker <fweisbec@...il.com>
> 
> But having a '\0' in a non binary trace looks weird. Why do
> we have such plain KMEMTRACE_USER_ALLOC whereas binary tracing
> is not set, as your example shows it?
> 

Because of this commit:

| commit 42af9054c0eeed09ec58d13ec8bf52d225ebcfcc
| Author: Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
| Date:   Mon Mar 23 15:12:26 2009 +0200
|
|    kmemtrace: restore original tracing data binary format, improve ABI

I think we should change it to use trace_event->binary() interface for
binary trace.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/