linux-kernel - Re: CONFIG_VFAT_FS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19021.20449.732095.210252@samba.org>
Date:	Fri, 3 Jul 2009 10:25:05 +1000
From:	tridge@...ba.org
To:	Jan Engelhardt <jengelh@...ozas.de>
Cc:	Theodore Tso <tytso@....edu>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Pavel Machek <pavel@....cz>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	john.lanza@...ux.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>, corbet@....net,
	jcm@...masters.org
Subject: Re: CONFIG_VFAT_FS_DUALNAMES regression

Hi Jan,

 > Then, I just tried everything to get an overview:

thanks!

 >  (All with DUALNAMES=n)
 >  # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=lower
 >  # cp /mnt/dcim/100_fuji/dscf{4160,3004}.jpg
 >  # umount /mnt
 >  # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=win95
 >  # cp /mnt/dcim/100_fuji/dscf{4160,3005}.jpg
 >  # umount /mnt
 >  # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=winnt
 >  # cp /mnt/dcim/100_fuji/dscf{4160,3006}.jpg
 >  # umount /mnt
 >  # mount /dev/sdc1 /mnt -o iocharset=utf8,shortnames=mixed
 >  # cp /mnt/dcim/100_fuji/dscf{4160,3007}.jpg
 >  # umount /mnt
 > 
 > Result? The camera only displays 3006.
 > 
 > The dualnames patch's filling filenames with random illegal
 > chars does seems to have a really foul side-effect after 

actually, you've just proved the patch works as intended on your
device!

Only the shortname=winnt would create a 8.3 name when you use the
filename dscfNNNN.jpg. That is why my first patch in May forced 

   shortname_flags = VFAT_SFN_CREATE_WINNT;

when the patch triggered. I think this is the only sane behaviour for
a VFAT filesystem on Linux. Unfortunately it isn't the default, and at
least on my Ubuntu system the automatic mounting doesn't get this
right.

I'd love to change the default or do an override, at least when
dualnames is diabled. Hirofumi-san, what do you think?

Cheers, Tridge

PS: I'm assuming you actually typed "shortname=" not
"shortnames=". The option is not plural.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/