linux-kernel - Re: [PATCH] vt: add an event interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090703102234.GA32128@elte.hu>
Date:	Fri, 3 Jul 2009 12:22:34 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] vt: add an event interface

* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > Your method leads to stuff like this in a recent commit:
> 
> Which is a cut and paste of code from the originals into the 
> helper.

and this changes my points how? It's not like it's hard to fix, and 
the code is moved non-trivially anyway, it's better to have it nicer 
if we touch it anyway.

> > Also note the inconsistent printk-ing lines, mutiliated by line 
> > warps. The use of pr_warning() would solve it:
> 
> Send patches if it bugs you that much. [...]

I find that a rather flippant attitude to kernel code quality 
issues.

Also, isnt it a double standard: why should newbies be held to 
higher standards than you hold yourself to?

Please just fix problems like everyone else is expected to fix it 
too and you wont get such review feedback.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/