linux-kernel - Re: [PATCH 1/4] MFD/PCAP: fix adc locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090703105235.GE4176@sortiz.org>
Date:	Fri, 3 Jul 2009 12:52:36 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Daniel Ribeiro <drwyrm@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	openezx-devel <openezx-devel@...ts.openezx.org>
Subject: Re: [PATCH 1/4] MFD/PCAP: fix adc locking

On Tue, Jun 23, 2009 at 12:30:58PM -0300, Daniel Ribeiro wrote:
> Release the lock on error.
Applied this one to my for-linus branch, which means I send a pull request to
Linus soon.
The 3 other patches are on my for-next branch.

Cheers,
Samuel.

 
> Signed-off-by: Daniel Ribeiro <drwyrm@...il.com>
> 
> ---
>  drivers/mfd/ezx-pcap.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
> index 671a7ef..c1de4af 100644
> --- a/drivers/mfd/ezx-pcap.c
> +++ b/drivers/mfd/ezx-pcap.c
> @@ -238,8 +238,10 @@ static irqreturn_t pcap_adc_irq(int irq, void *_pcap)
>  	mutex_lock(&pcap->adc_mutex);
>  	req = pcap->adc_queue[pcap->adc_head];
>  
> -	if (WARN(!req, KERN_WARNING "adc irq without pending request\n"))
> +	if (WARN(!req, KERN_WARNING "adc irq without pending request\n")) {
> +		mutex_unlock(&pcap->adc_mutex);
>  		return IRQ_HANDLED;
> +	}
>  
>  	/* read requested channels results */
>  	ezx_pcap_read(pcap, PCAP_REG_ADC, &tmp);
> -- 
> tg: (f234012..) pcap/fix-adc-locking (depends on: master)
> 
> -- 
> Daniel Ribeiro



-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/