Message-ID: <20090703160230.093e422c@lxorguk.ukuu.org.uk>
Date:	Fri, 3 Jul 2009 16:02:30 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] vt: add an event interface

> It's an argument you made on false premises.
> 
> The thing is, my review wasnt about old code being moved around. It 
> was about new code being introduced by you:

Ingo, if you've nothing better to do than quote out of context and be
offensive, perhaps you should go fix voyager support or something
productive instead.

The reply section you are quoting was about the code that was moved from
place to place. I stand by that comment - you don't move code from place
to place and reformat, rework it in one go. It's lousy engineering.

> 
> +       if (copy_from_user(&vw.event, (void __user *)arg, sizeof(struct vt_event)))
> +               return -EFAULT;
> +       /* Highest supported event for now */
> +       if(vw.event.event > VT_MAX_EVENT)
> +               return -EINVAL;
> 
> Same pattern as in the old commit: you used differing styles just 3 
> lines apart in new code and apparently didnt even notice it. So i 
> dont buy your argument at all that you will do 'cleanups later' as 
> your patch shows ignorance of the whole concept.

Which was a draft patch with a question, it hadn't even been compiled and
it was obvious at first glance it contained errors - yet you didn't
notice that just spaces.

> > checkpatch is a tool, not a religion. [...]
> 
> The thing is, you didnt really answer my question whether you 
> consider yourself to be accountable to the same standards of quality 
> as other upstream kernel contributors?

I did answer it, I guess you didn't like the answer ?

> But you are not a newbie driver submitter, are you? Do you consider 
> yourself exempt from accepted rules of cleanliness, for new code you 
> submit?

This wasn't code being submitted - which has been pointed out to you
several times.

> > The message I thought was quite clear about what I was asking for. 
> > The fact you complained about spaces and missed the fact it 
> > couldn't even work was "enlightening" in terms of code review.
> 
> Here, in support of advancing a false argument you materially 

You mean you think its not relevant that you saw spacing and format
differences but couldn't spot the fact the code had obvious errors and
hadn't been compiled ? Its a sketch no more.

> This goes beyond 'spaces'. Type cleanliness is the first and most 
> important thing when designing new interfaces - and you just added a 
> new unclean interface in form of vt_event_wait_ioctl().

See comment #1 made in the very first message to you - it was an initial
draft, and if you'd stop trying to cover the fact you were so space and
formatting obsessed you missed the fact it wasn't even compilable code
perhaps we'd get somewhere useful.

Finally look up "Signed-off-by:", if you think it means "this is code I
think is perfection" you are wrong. I quote

"The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right to
pass it on as a open-source patch."

Period and the draft I posted is exactly that.

Now if you'll pardon me I have real work to do while you macdink
space characters.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists