linux-kernel - Re: [PATCH -tip] x86: atomic64: inline atomic64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.01.0907031207030.3210@localhost.localdomain>
Date:	Fri, 3 Jul 2009 12:10:23 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Eric Dumazet <eric.dumazet@...il.com>, mingo@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -tip] x86: atomic64: inline atomic64_read()

On Fri, 3 Jul 2009, Ingo Molnar wrote:
> > +
> > +	asm volatile(
> > +		"mov %%ebx, %%eax\n\t"
> > +		"mov %%ecx, %%edx\n\t"
> > +		LOCK_PREFIX "cmpxchg8b %1\n"
> > +			: "=&A" (res)
> > +			: "m" (*ptr) 
> > +		);
> 
> That clobbers or affects eax, ebx, ecx, edx. The only registers it 
> does not clobber is esi, edi and rbp.

No, it only clobbers eax/edx. Yes, it touches ebx/ecx, but that's kind of 
incidental, and read-only, and doesn't matter.

> Linus, what's your preference in this case?

I think it's kind of subtle to do that thing, but it _is_ very much a 
special case. It's odd to use a cmpxchg8b to just do a read in the first 
place, so the fact that we then play other games with it is kind of 
immaterial.

Adding a comment about the magic "we don't care about the initial values 
in eax/edx and ebx/ecx, but they have to match in case we end up doing a 
writeback" might be a good idea.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/