linux-kernel - Re: [microblaze-uclinux] [RFC PATCH] linker script: unify usage of discard definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A4FA212.8030506@monstr.eu>
Date:	Sat, 04 Jul 2009 20:40:18 +0200
From:	Michal Simek <monstr@...str.eu>
To:	microblaze-uclinux@...e.uq.edu.au
CC:	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Michal Simek <monstr@...str.eu>,
	Sam Ravnborg <sam@...nborg.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	Tony Luck <tony.luck@...el.com>, tj@...nel.org
Subject: Re: [microblaze-uclinux] [RFC PATCH] linker script: unify usage of
 discard definition



Tejun Heo wrote:
> Discarded sections in different archs share some commonality but have
> considerable differences.  This led to linker script for each arch
> implementing its own /DISCARD/ definition, which makes maintaining
> tedious and adding new entries error-prone.
> 
> This patch makes all linker scripts to move discard definitions to the
> end of the linker script and use the common DISCARDS macro.  As ld
> uses the first matching section definition, archs can include default
> discarded sections by including them earlier in the linker script.
> 
> On x86-64 which explicitly includes EXIT_TEXT, this produces identical
> output as before and all but one archs included directives (include or
> discard) for all default discarded sections, so this patch shouldn't
> cause any behavior difference.
> 
> The only problem case is microblaze, which didn't explicitly included
> EXIT_TEXT and DATA but didn't discard them either leaving ld to create
> identically names output sections for them.  This patch will make the
> end result different by throwing away exit text and data.  It looks
> like the ommission was accidental and throwing away is the right thing
> to do, but I won't push it till someone who knows microblaze confirms
> it.

As you expected noMMU Microblaze kernel has some problems with that patch. (MMU version is fine)
I'll take a look at it closer yesterday.

Thanks,
Michal



> ___________________________
> microblaze-uclinux mailing list
> microblaze-uclinux@...e.uq.edu.au
> Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
> Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
> 
> 


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/