linux-kernel - Re: [PATCH 3/3 -tip] perf list: avoid replicating functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090704095023.GB2139@elte.hu>
Date:	Sat, 4 Jul 2009 11:50:23 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Paul Mackerras <paulus@...ba.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Anton Blanchard <anton@...ba.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 3/3 -tip] perf list: avoid replicating functions


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> On Fri, 2009-07-03 at 11:30 +0200, Ingo Molnar wrote:
> > * Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> > 
> > > > $ ./perf list shows vector events like :
> > > > 
> > > >   vec-adds OR add                          [Hardware vector event]
> > > >   vec-muls OR multiply                     [Hardware vector event]
> > > >   vec-divs OR divide                       [Hardware vector event]
> > > >   vec-idle-cycles OR vec-empty-cycles      [Hardware vector event]
> > > >   vec-stall-cycles OR vec-busy-cycles      [Hardware vector event]
> > > >   vec-ops OR vec-operations                [Hardware vector event]
> > 
> > btw., why does this printout SHOUT the 'or'? It's certainly not an 
> > important piece of information. Something like:
> > 
> >    vec-adds | add                          [Hardware vector event]
> >    vec-muls | multiply                     [Hardware vector event]
> >    vec-divs | divide                       [Hardware vector event]
> >    vec-idle-cycles | vec-empty-cycles      [Hardware vector event]
> >    vec-stall-cycles | vec-busy-cycles      [Hardware vector event]
> >    vec-ops | vec-operations                [Hardware vector event]
> > 
> > looks better on all levels.
> > 
> 
> I prepared this patch incrementally on : 
> [PATCH 1/2 -tip] perf_counter: Add generalized hardware vectored co-processor support for AMD and Intel Corei7/Nehalem
> [PATCH 2/2 -tip] perf_counter: Add generalized hardware interrupt support for AMD and Intel Corei7/Nehalem, Core2 and Atom
> 
> [PATCH 3/3] perf list: avoid replicating functions
> 
> vector and interrupt can use same function made for hardware and 
> software generic events.
> 
> Also replaced 'OR' with '|'

Please submit a clean series of patches instead of a mixture of 
patches plus fixes to patches.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/