linux-kernel - Re: [PATCH 5/5] perf report: Support callchains with relative overhead rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090705132333.GB4912@nowhere>
Date:	Sun, 5 Jul 2009 15:23:35 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mike Galbraith <efault@....de>,
	Paul Mackerras <paulus@...ba.org>,
	Anton Blanchard <anton@...ba.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 5/5] perf report: Support callchains with relative
	overhead rate

On Sun, Jul 05, 2009 at 10:59:49AM +0200, Ingo Molnar wrote:
> 
> btw., i get some buggy looking output with:
> 
>   $ perf record -f -g ~/hackbench 10
> 
>   $ perf report -c
> 
> 
>                 |--5.11%-- unix_stream_sendmsg
>                 |          |          
>                 |          |--100.00%-- __sock_sendmsg
>                 |          |          sock_aio_write
>                 |          |          do_sync_write
>                 |          |          vfs_write
>                 |          |          sys_write
>                 |          |          sysenter_dispatch
>                 |          |          0xf7f72430
>                 |          |          0xffebbca000000014
>                 |          |          
>                 |           --11.11%-- sock_aio_write
>                 |                     do_sync_write
>                 |                     vfs_write
>                 |                     sys_write
>                 |                     sysenter_dispatch
>                 |                     0xf7f72430
>                 |                     0xffebbca000000014
> 
> Those percentages dont sum up to 100% :-)


Argh. I can reproduce it, will have a look.


> Another detail: i think we should signal when we crop the output due 
> to the filter, via a line of:
> 
>                 |          [...]
> 
> or so.


Ok.



> Plus, when doing 'perf report' on a call-chain recording, shouldnt 
> we auto-detect this fact and default to fractal output 
> automatically, instead of flat mode?
> 
> User can still force flat mode via 'perf report -c flat'.


Yeah but the user won't be able to ignore the callchain.
May be I may add a -c none in this case?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/