linux-kernel - Re: [tip:x86/cleanups] x86: Clean up mtrr/cleanup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 5 Jul 2009 20:04:14 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Yinghai Lu <yinghai@...nel.org>, mingo@...hat.com, hpa@...or.com,
	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	jaswinderrajput@...il.com, akpm@...ux-foundation.org,
	tglx@...utronix.de, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/cleanups] x86: Clean up mtrr/cleanup.c


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> On Sun, 2009-07-05 at 02:27 +0200, Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@...nel.org> wrote:
> > 
> > > >  static struct var_mtrr_range_state __initdata range_state[RANGE_NUM];
> > > > +
> > > >  static int __initdata debug_print;
> > > > +#define Dprintk(x...) do { if (debug_print) printk(KERN_DEBUG x); } while (0)
> > > > +
> > > > +
> > > 
> > > two blank lines?
> > 
> > ah, yes - i moved them around.
> > 
> > > > +#define BIOS_BUG_MSG KERN_WARNING \
> > > > +	"WARNING: BIOS bug: VAR MTRR %d contains strange UC entry under 1M, check with your system vendor!\n"
> > > 
> > > No user for this
> > 
> > yeah. Mind sending a patch for these? (and any other things you 
> > might notice)
> 
> But why you did this stupidity.

Uhm, no. This was an unused define that i made later use of in:

  e3d0e69: x86: Further clean up of mtrr/generic.c

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/