linux-kernel - Re: [PATCH v3]mempool.c : clean up type-casting twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246785216.4358.4.camel@myhost>
Date:	Sun, 05 Jul 2009 17:13:36 +0800
From:	"Figo.zhang" <figo1802@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...l.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3]mempool.c : clean up type-casting twice

On Sun, 2009-07-05 at 11:04 +0200, Ingo Molnar wrote:
> * Figo.zhang <figo1802@...il.com> wrote:
> 
> > clean up type-casting twice. "size_t" typedef as "unsigned long" in 64-bit system,
> > and "unsigned int" in 32-bit system.
> 
> [
>   You should line-length limit your changelogs btw., to 60 
>   characters or so. git log will add another 4 characters. The 
>   ~/.vimrc magic for this is:
> 
>   autocmd BufNewFile,BufRead *.patch setlocal textwidth=60
> ]

hi,Ingo,

Thanks a lot.

should i motify the log, and send it again?

Best,
Figo.zhang


> 
> > 
> > in v3, remove the space to casts.
> > 
> > Signed-off-by: Figo.zhang <figo1802@...il.com>
> > ---    
> > mm/mempool.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/mm/mempool.c b/mm/mempool.c
> > index a46eb1b..32e75d4 100644
> > --- a/mm/mempool.c
> > +++ b/mm/mempool.c
> > @@ -303,14 +303,14 @@ EXPORT_SYMBOL(mempool_free_slab);
> >   */
> >  void *mempool_kmalloc(gfp_t gfp_mask, void *pool_data)
> >  {
> > -	size_t size = (size_t)(long)pool_data;
> > +	size_t size = (size_t)pool_data;
> >  	return kmalloc(size, gfp_mask);
> >  }
> >  EXPORT_SYMBOL(mempool_kmalloc);
> >  
> >  void *mempool_kzalloc(gfp_t gfp_mask, void *pool_data)
> >  {
> > -	size_t size = (size_t) pool_data;
> > +	size_t size = (size_t)pool_data;
> >  	return kzalloc(size, gfp_mask);
> >  }
> >  EXPORT_SYMBOL(mempool_kzalloc);
> 
> Acked-by: Ingo Molnar <mingo@...e.hu>
> 
> 	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/