linux-kernel - Re: [PATCH 05/10] writeback: support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090706122211.GO23611@kernel.dk>
Date:	Mon, 6 Jul 2009 14:22:12 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	chris.mason@...cle.com, david@...morbit.com, hch@...radead.org,
	akpm@...ux-foundation.org, jack@...e.cz,
	yanmin_zhang@...ux.intel.com, richard@....demon.co.uk,
	damien.wyart@...e.fr, fweisbec@...il.com, Alan.Brunelle@...com
Subject: Re: [PATCH 05/10] writeback: support > 1 flusher thread per bdi

On Mon, Jul 06 2009, Artem Bityutskiy wrote:
> Jens Axboe wrote:
>> +static struct bdi_work *bdi_alloc_work(struct super_block *sb, long nr_pages,
>> +				       enum writeback_sync_modes sync_mode)
>> +{
>> +	struct bdi_work *work;
>> +
>> +	work = kmalloc(sizeof(*work), GFP_ATOMIC);
>> +	if (work)
>> +		bdi_work_init(work, sb, nr_pages, sync_mode);
>>  -	wb_start_writeback(&bdi->wb, sb, nr_pages, sync_mode);
>> +	return work;
>> +}
>
> Since the caller of this function handles kmalloc failure gracefully,
> should we also pass __GFP_NOWARN flag to kmalloc() here, in order to
> avoid large and scary no-memory complaints?

Sure, it can't hurt.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/