lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4A514177.4000505@necel.com>
Date:	Mon, 06 Jul 2009 09:12:39 +0900
From:	Shinya Kuribayashi <shinya.kuribayashi@...el.com>
To:	Ralf Baechle <ralf@...ux-mips.org>
CC:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>,
	skuribay@...y.dti.ne.jp, trivial@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Trivial: Fix filenames in their headers for the	EMMA
 Mark-eins.

Ralf Baechle wrote:
> Different suggestion - let's remove these comment lines entirely.  I just
> don't see any use for them.  So this patch removes them along with a few
> very obvious comments.

I like this one.

>  arch/mips/dec/ecc-berr.c                          |    2 --
>  arch/mips/dec/int-handler.S                       |    2 --
>  arch/mips/dec/ioasic-irq.c                        |    2 --
>  arch/mips/dec/kn01-berr.c                         |    2 --
>  arch/mips/dec/kn02-irq.c                          |    2 --
>  arch/mips/dec/kn02xa-berr.c                       |    2 --
>  arch/mips/dec/prom/call_o32.S                     |    2 --
>  arch/mips/dec/prom/console.c                      |    2 --
>  arch/mips/dec/time.c                              |    2 --
>  arch/mips/emma/common/Makefile                    |    3 ---
>  arch/mips/emma/common/prom.c                      |    3 ---
>  arch/mips/emma/markeins/Makefile                  |    3 ---
>  arch/mips/emma/markeins/irq.c                     |    3 ---
>  arch/mips/emma/markeins/led.c                     |    3 ---
>  arch/mips/emma/markeins/platform.c                |    3 ---
>  arch/mips/emma/markeins/setup.c                   |    3 ---

How about arch/mips/fw/lib/call_o32.S?

>  arch/mips/include/asm/emma/emma2rh.h              |    3 ---
>  arch/mips/include/asm/emma/markeins.h             |    3 ---
>  arch/mips/kernel/irq_txx9.c                       |    2 --
>  arch/mips/kernel/proc.c                           |    2 --
>  arch/mips/kernel/stacktrace.c                     |    2 --
>  arch/mips/mm/extable.c                            |    3 ---
>  arch/mips/pci/fixup-emma2rh.c                     |    3 ---
>  arch/mips/pci/fixup-sb1250.c                      |    2 --
>  arch/mips/pci/ops-emma2rh.c                       |    3 ---
>  arch/mips/pci/pci-emma2rh.c                       |    3 ---
>  arch/mips/pci/pci-tx4927.c                        |    2 --
>  arch/mips/pci/pci-tx4938.c                        |    2 --
>  arch/mips/pci/pci-tx4939.c                        |    2 --
>  arch/mips/pmc-sierra/msp71xx/gpio.c               |    2 --
>  arch/mips/pmc-sierra/msp71xx/gpio_extended.c      |    2 --
>  arch/mips/pmc-sierra/yosemite/atmel_read_eeprom.c |    2 --
>  arch/mips/sibyte/swarm/swarm-i2c.c                |    2 --
>  arch/mips/txx9/generic/mem_tx4927.c               |    2 --
>  arch/mips/txx9/generic/setup.c                    |    2 --
>  35 files changed, 0 insertions(+), 83 deletions(-)

[...]

> diff --git a/arch/mips/mm/extable.c b/arch/mips/mm/extable.c
> index 297fb9f..e94ea59 100644
> --- a/arch/mips/mm/extable.c
> +++ b/arch/mips/mm/extable.c
> @@ -1,6 +1,3 @@
> -/*
> - * linux/arch/mips/mm/extable.c
> - */
>  #include <linux/module.h>
>  #include <linux/spinlock.h>
>  #include <asm/branch.h>

Btw, let's have extable.c have, at least, a copyright later.

Acked-by: Shinya Kuribayashi <shinya.kuribayashi@...el.com>

-- 
Shinya Kuribayashi
NEC Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ