lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 06 Jul 2009 11:13:24 +0800 From: Alex Shi <alex.shi@...el.com> To: Yinghai Lu <yinghai@...nel.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, Ingo Molnar <mingo@...e.hu>, "bugzilla-daemon@...zilla.kernel.org" <bugzilla-daemon@...zilla.kernel.org>, "bugme-daemon@...zilla.kernel.org" <bugme-daemon@...zilla.kernel.org>, Christoph Lameter <cl@...ux-foundation.org>, Mel Gorman <mel@....ul.ie>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Zhang, Yanmin" <yanmin.zhang@...el.com>, "Chen, Tim C" <tim.c.chen@...el.com> Subject: Re: [Bugme-new] [Bug 13690] New: nodes_clear cause hugepage unusable on non-NUMA machine Yinghai: The 31-rc2 kernel still can not use hugepage on non-NUMA machine. And this patch did not appear on rc2 kernel. Are there some concern about this? BRG Alex On Thu, 2009-07-02 at 16:50 +0800, Yinghai Lu wrote: > Alex Shi wrote: > > The new patch works for my stoakley i386 machine. But for x86_64 machine > > the specjbb2005 still can not run with hugepage. The specjbb2005 use the > > same java setting as i386 system. After apply your patch, the iomem of > > x86_64 is: > > please check > > [PATCH] x86: don't clear nodes_states[N_NORMAL_MEMORY] when numa is not compiled in > > Alex found: > for x86_64 machine the specjbb2005 still can not run with hugepage > > only happens when numa is not compiled in > > the root cause: node_set_state will not set it back for us in that case > > so don't clear that when numa is not select in config > > Reported-by: Alex Shi <alex.shi@...el.com> > Signed-off-by: Yinghai Lu <yinghai@...nel.org> > > --- > arch/x86/mm/init_64.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > Index: linux-2.6/arch/x86/mm/init_64.c > =================================================================== > --- linux-2.6.orig/arch/x86/mm/init_64.c > +++ linux-2.6/arch/x86/mm/init_64.c > @@ -598,8 +598,14 @@ void __init paging_init(void) > > sparse_memory_present_with_active_regions(MAX_NUMNODES); > sparse_init(); > - /* clear the default setting with node 0 */ > +#if MAX_NUMNODES > 1 > + /* > + * clear the default setting with node 0 > + * note: don't clear it, node_set_state will do nothing > + * (aka set it back) when numa support is not compiled in > + */ > nodes_clear(node_states[N_NORMAL_MEMORY]); > +#endif > free_area_init_nodes(max_zone_pfns); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists