linux-kernel - Re: [PATCH] kmemcheck: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A523135.40408@cs.helsinki.fi>
Date:	Mon, 06 Jul 2009 20:15:33 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Johannes Berg <johannes@...solutions.net>
CC:	Vegard Nossum <vegard.nossum@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kmemcheck: fix sparse warning

Johannes Berg wrote:
> Whether or not the sparse warning
> 
> warning: do-while statement is not a compound statement
> 
> is justified or not in this case, it is annoying and
> trivial to fix.
> 
> Signed-off-by: Johannes Berg <johannes@...solutions.net>

Looks good to me!

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

> ---
>  include/linux/kmemcheck.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- wireless-testing.orig/include/linux/kmemcheck.h	2009-07-06 11:41:16.000000000 +0200
> +++ wireless-testing/include/linux/kmemcheck.h	2009-07-06 11:41:30.000000000 +0200
> @@ -137,13 +137,13 @@ static inline void kmemcheck_mark_initia
>  	int name##_end[0];
>  
>  #define kmemcheck_annotate_bitfield(ptr, name)				\
> -	do if (ptr) {							\
> +	do { if (ptr) {							\
>  		int _n = (long) &((ptr)->name##_end)			\
>  			- (long) &((ptr)->name##_begin);		\
>  		BUILD_BUG_ON(_n < 0);					\
>  									\
>  		kmemcheck_mark_initialized(&((ptr)->name##_begin), _n);	\
> -	} while (0)
> +	} } while (0)
>  
>  #define kmemcheck_annotate_variable(var)				\
>  	do {								\
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/