linux-kernel - Re: [PATCH] Remove multiple KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246912693.4643.17.camel@Joe-Laptop.home>
Date:	Mon, 06 Jul 2009 13:38:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Mike Frysinger <vapier.adi@...il.com>,
	Yinghai Lu <yinghai@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Remove multiple KERN_ prefixes from printk formats

On Mon, 2009-07-06 at 13:33 -0700, Linus Torvalds wrote:
> 
> On Mon, 6 Jul 2009, Mike Frysinger wrote:
> > >  #ifdef CONFIG_DEBUG_VERBOSE
> > > -       printk(KERN_EMERG "\n" KERN_EMERG "Double Fault\n");
> > > +       printk(KERN_EMERG "Double Fault\n");
> > 
> > dropped a newline.  we've largely made sure the newlines and such were
> > as we want in the output ... in this case, it is not a matter of
> > adding a newline where one did not exist before
> 
> Note that the 'printk' itself will add a required newline these days.
> 
> So unless you want an _empty_ line due to an earlier '\n', the change is 
> correct.

Note the prefix before and after the "\n"
I believe he _wants_ an empty line.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/