linux-kernel - Re: [PATCH 5/5] sparc: use asm-generic/pci-dma-compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907061021.28360.arnd@arndb.de>
Date:	Mon, 6 Jul 2009 10:21:28 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	davem@...emloft.net, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, reif@...thlink.net
Subject: Re: [PATCH 5/5] sparc: use asm-generic/pci-dma-compat

On Monday 06 July 2009, FUJITA Tomonori wrote:

> --- a/arch/sparc/include/asm/pci_64.h
> +++ b/arch/sparc/include/asm/pci_64.h
> -/* Return whether the given PCI device DMA address mask can
> - * be supported properly.  For example, if your device can
> - * only drive the low 24-bits during PCI bus mastering, then
> - * you would pass 0x00ffffff as the mask to this function.
> - */
> -extern int pci_dma_supported(struct pci_dev *hwdev, u64 mask);
> -
>  /* PCI IOMMU mapping bypass support. */
>  
>  /* PCI 64-bit addressing works for all slots on all controller
> --- a/arch/sparc/kernel/iommu.c
> +++ b/arch/sparc/kernel/iommu.c
> @@ -840,6 +840,8 @@ static struct dma_map_ops sun4u_dma_ops = {
>  struct dma_map_ops *dma_ops = &sun4u_dma_ops;
>  EXPORT_SYMBOL(dma_ops);
>  
> +extern int pci64_dma_supported(struct pci_dev *pdev, u64 device_mask);
> +
>  int dma_supported(struct device *dev, u64 device_mask)
>  {
>  	struct iommu *iommu = dev->archdata.iommu;

Minor nitpicking: The declaration should better be left in the header
file to avoid extern declarations in C files.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/