lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1246868692.4957.12.camel@penberg-laptop>
Date:	Mon, 06 Jul 2009 11:24:52 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kmemtrace: rename some functions

On Mon, 2009-07-06 at 16:15 +0800, Li Zefan wrote:
> So we have:
> - kmemtrace_print_alloc/free() for kmemtrace default output
> - kmemtrace_print_alloc/free_user() for binary output used
>   by kmemtrace-user.
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

I think this is what you suggested Eduard?

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

> ---
> 
> forgot to CC LKML...again..
> 
> ---
>  kernel/trace/kmemtrace.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/kernel/trace/kmemtrace.c b/kernel/trace/kmemtrace.c
> index 74903b6..256827b 100644
> --- a/kernel/trace/kmemtrace.c
> +++ b/kernel/trace/kmemtrace.c
> @@ -239,7 +239,7 @@ struct kmemtrace_user_event_alloc {
>  };
>  
>  static enum print_line_t
> -kmemtrace_print_alloc_user(struct trace_iterator *iter, int flags)
> +kmemtrace_print_alloc(struct trace_iterator *iter, int flags)
>  {
>  	struct trace_seq *s = &iter->seq;
>  	struct kmemtrace_alloc_entry *entry;
> @@ -259,7 +259,7 @@ kmemtrace_print_alloc_user(struct trace_iterator *iter, int flags)
>  }
>  
>  static enum print_line_t
> -kmemtrace_print_free_user(struct trace_iterator *iter, int flags)
> +kmemtrace_print_free(struct trace_iterator *iter, int flags)
>  {
>  	struct trace_seq *s = &iter->seq;
>  	struct kmemtrace_free_entry *entry;
> @@ -277,7 +277,7 @@ kmemtrace_print_free_user(struct trace_iterator *iter, int flags)
>  }
>  
>  static enum print_line_t
> -kmemtrace_print_alloc_user_bin(struct trace_iterator *iter, int flags)
> +kmemtrace_print_alloc_user(struct trace_iterator *iter, int flags)
>  {
>  	struct trace_seq *s = &iter->seq;
>  	struct kmemtrace_alloc_entry *entry;
> @@ -311,7 +311,7 @@ kmemtrace_print_alloc_user_bin(struct trace_iterator *iter, int flags)
>  }
>  
>  static enum print_line_t
> -kmemtrace_print_free_user_bin(struct trace_iterator *iter, int flags)
> +kmemtrace_print_free_user(struct trace_iterator *iter, int flags)
>  {
>  	struct trace_seq *s = &iter->seq;
>  	struct kmemtrace_free_entry *entry;
> @@ -482,14 +482,14 @@ static enum print_line_t kmemtrace_print_line(struct trace_iterator *iter)
>  
>  static struct trace_event kmem_trace_alloc = {
>  	.type			= TRACE_KMEM_ALLOC,
> -	.trace			= kmemtrace_print_alloc_user,
> -	.binary			= kmemtrace_print_alloc_user_bin,
> +	.trace			= kmemtrace_print_alloc,
> +	.binary			= kmemtrace_print_alloc_user,
>  };
>  
>  static struct trace_event kmem_trace_free = {
>  	.type			= TRACE_KMEM_FREE,
> -	.trace			= kmemtrace_print_free_user,
> -	.binary			= kmemtrace_print_free_user_bin,
> +	.trace			= kmemtrace_print_free,
> +	.binary			= kmemtrace_print_free_user,
>  };
>  
>  static struct tracer kmem_tracer __read_mostly = {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ