linux-kernel - Re: [PATCH 2/5] sparc: use asm-generic/dma-mapping-common.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jul 2009 18:11:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	fujita.tomonori@....ntt.co.jp, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, reif@...thlink.net
Subject: Re: [PATCH 2/5] sparc: use asm-generic/dma-mapping-common.h

From: Arnd Bergmann <arnd@...db.de>
Date: Mon, 6 Jul 2009 10:26:28 +0200

> On Monday 06 July 2009, FUJITA Tomonori wrote:
>> +static inline struct dma_map_ops *get_dma_ops(struct device *dev)
>> +{
>> +       return dma_ops;
>> +}
>> +
>> +#define flush_write_buffers()
>> +
>> +#include <asm-generic/dma-mapping-common.h>
> 
> I still think the flush_write_buffers() x86-ism should not be required
> to use dma-mapping-common.h and only be used in arch/x86/kernel/pci-nommu.c
> so you don't have to add dummy definitions to all architectures.
> 
> See http://lkml.org/lkml/2009/6/30/134
> 
> Otherwise, your series looks good!

Since we have until the 2.6.32 merge window to merge this, why
don't we take care of this flush_write_buffers() thing first?

I'm completely fine with these changes otherwise, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/