[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 07 Jul 2009 08:18:09 +0200
From: Németh Márton <nm127@...email.hu>
To: Mauro Carvalho Chehab <mchehab@...radead.org>,
Jean-Francois Moine <moinejf@...e.fr>,
linux-media@...r.kernel.org
CC: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/2] v4l2: remove unnecessary vidioc_s_std() from gspca
From: Márton Németh <nm127@...email.hu>
The vidioc_s_std() is not necessary when vdev->tvnorms == 0. [1]
The changeset was tested together with v4l-test 0.16 [2] with
gspca_sunplus driver together with Trust 610 LCD POWERC@M ZOOM.
References:
[1] V4L2 API specification, revision 0.24
http://v4l2spec.bytesex.org/spec/x448.htm
[2] v4l-test: Test environment for Video For Linux Two API
http://v4l-test.sourceforge.net/
Signed-off-by: Márton Németh <nm127@...email.hu>
---
--- linux-2.6.31-rc1/drivers/media/video/gspca/gspca.c.orig 2009-06-25 01:25:37.000000000 +0200
+++ linux-2.6.31-rc1/drivers/media/video/gspca/gspca.c 2009-07-06 08:14:19.000000000 +0200
@@ -1405,12 +1405,6 @@ static int vidioc_s_parm(struct file *fi
return 0;
}
-static int vidioc_s_std(struct file *filp, void *priv,
- v4l2_std_id *parm)
-{
- return 0;
-}
-
#ifdef CONFIG_VIDEO_V4L1_COMPAT
static int vidiocgmbuf(struct file *file, void *priv,
struct video_mbuf *mbuf)
@@ -1881,7 +1875,6 @@ static const struct v4l2_ioctl_ops dev_i
.vidioc_s_jpegcomp = vidioc_s_jpegcomp,
.vidioc_g_parm = vidioc_g_parm,
.vidioc_s_parm = vidioc_s_parm,
- .vidioc_s_std = vidioc_s_std,
.vidioc_enum_framesizes = vidioc_enum_framesizes,
#ifdef CONFIG_VIDEO_V4L1_COMPAT
.vidiocgmbuf = vidiocgmbuf,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists