linux-kernel - Re: [RFC PATCH 1/2] vmscan don't isolate too many pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28c262360907071639g4877b2c2w59a8eae8559557f7@mail.gmail.com>
Date:	Wed, 8 Jul 2009 08:39:12 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	Wu Fengguang <fengguang.wu@...el.com>
Subject: Re: [RFC PATCH 1/2] vmscan don't isolate too many pages

On Tue, Jul 7, 2009 at 6:47 PM, KOSAKI
Motohiro<kosaki.motohiro@...fujitsu.com> wrote:
> Subject: [PATCH] vmscan don't isolate too many pages
>
> If the system have plenty threads or processes, concurrent reclaim can
> isolate very much pages.
>
> And if other processes isolate _all_ pages on lru, the reclaimer can't find
> any reclaimable page and it makes accidental OOM.
>
> The solusion is, we should restrict maximum number of isolated pages.
> (this patch use inactive_page/2)
>
>
> FAQ
> -------
> Q: Why do you compared zone accumulate pages, not individual zone pages?
> A: If we check individual zone, #-of-reclaimer is restricted by smallest zone.
>   it mean decreasing the performance of the system having small dma zone.
>
>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> ---
>  mm/page_alloc.c |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> Index: b/mm/page_alloc.c
> ===================================================================
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1721,6 +1721,28 @@ gfp_to_alloc_flags(gfp_t gfp_mask)
>        return alloc_flags;
>  }
>
> +static bool too_many_isolated(struct zonelist *zonelist,
> +                             enum zone_type high_zoneidx, nodemask_t *nodemask)
> +{
> +       unsigned long nr_inactive = 0;
> +       unsigned long nr_isolated = 0;
> +       struct zoneref *z;
> +       struct zone *zone;
> +
> +       for_each_zone_zonelist_nodemask(zone, z, zonelist,
> +                                       high_zoneidx, nodemask) {
> +               if (!populated_zone(zone))
> +                       continue;
> +
> +               nr_inactive += zone_page_state(zone, NR_INACTIVE_ANON);
> +               nr_inactive += zone_page_state(zone, NR_INACTIVE_FILE);
> +               nr_isolated += zone_page_state(zone, NR_ISOLATED_ANON);
> +               nr_isolated += zone_page_state(zone, NR_ISOLATED_FILE);
> +       }
> +
> +       return nr_isolated > nr_inactive;
> +}
> +
>  static inline struct page *
>  __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order,
>        struct zonelist *zonelist, enum zone_type high_zoneidx,
> @@ -1789,6 +1811,11 @@ rebalance:
>        if (p->flags & PF_MEMALLOC)
>                goto nopage;
>
> +       if (too_many_isolated(gfp_mask, zonelist, high_zoneidx, nodemask)) {

too_many_isolated(zonelist, high_zoneidx, nodemask)

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/