linux-kernel - Re: [PATCH 1/8] ksym_tracer: Extract trace entry from struct trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A53EE88.1080003@cn.fujitsu.com>
Date:	Wed, 08 Jul 2009 08:55:36 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	"K.Prasad" <prasad@...ux.vnet.ibm.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/8] ksym_tracer: Extract trace entry from struct	trace_ksym

>> -	entry = ring_buffer_event_data(event);
>> +	entry		= ring_buffer_event_data(event);
>> +	entry->ip	= instruction_pointer(regs);
>> +	entry->type	= hbp->info.type;
>>  	strlcpy(entry->ksym_name, hbp->info.name, KSYM_SYMBOL_LEN);
>> -	entry->ksym_hbp = hbp;
>> -	entry->ip = instruction_pointer(regs);
>> -	strlcpy(entry->p_name, current->comm, TASK_COMM_LEN);
>> +	strlcpy(entry->cmd, current->comm, TASK_COMM_LEN);
> 
> 
> Ah, I did not realized that the cmdline was that roughly saved.
> It would be more ring-buffer-friendly to use tracing_record_cmdline.
> 

Yeah, I'll send an incremental patch later.

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/