linux-kernel - Re: Bug in dmi_get_year (causing apic not getting enabled)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A5440FE.6000708@gmail.com>
Date:	Wed, 08 Jul 2009 08:47:26 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Matthias Pfaller <leo@...co.de>, linux-kernel@...r.kernel.org
Subject: Re: Bug in dmi_get_year (causing apic not getting enabled)

On 07/08/2009 07:36 AM, Eric W. Biederman wrote:
> Matthias Pfaller <leo@...co.de> writes:
> 
>> Hi,
>>
>> dmi_get_year extracts the year with:
>>
>> 	simple_strtoul(s, NULL, 0);
>>
>> for biosdates in 2008 and 2009 this will return 0 because 8 and 9 are no valid
>> octal digits. This will e.g. result in the apic not getting enabled.
>> Changing this to
>>
>> 	simple_strtoul(s, NULL, 10);
>>
>> should fix the problem.
> 
> Only if there is a leading 0....

Yes, 4-digit year is required as of smbios 2.3 (1998). There are broken
BIOSes out there though. So there is no need to guess base if we know
it. I sent a fix for this yesterday. Any objections?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/