linux-kernel - Re: Possible memory leak in request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247043394.25994.0.camel@macbook.infradead.org>
Date:	Wed, 08 Jul 2009 09:56:34 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Sachin Sant <sachinp@...ibm.com>
Subject: Re: Possible memory leak in request_firmware()

On Wed, 2009-07-08 at 16:42 +0800, Ming Lei wrote:
> 
> IMHO, No.
> If nr_pages is not cleaned, pages pointed by pages[] will be freed
> by fw_dev_release, but they should be freed by vfree()
> in release_firmware. Right?

Yes, sorry -- you're right, and the original patch is fine.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/