[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1247019117.2573.3.camel@myhost>
Date: Wed, 08 Jul 2009 10:11:57 +0800
From: "Figo.zhang" <figo1802@...il.com>
To: Tejun Heo <tj@...nel.org>
Cc: lkml <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>
Subject: [PATCH v2] vmalloc.c: fix double error checking
it is no need for double error checking.
in v2, if vmap_pud_ranger() error, directly return err.
Signed-off-by: Figo.zhang <figo1802@...il.com>
---
mm/vmalloc.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index f8189a4..ed6b4b9 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -168,11 +168,9 @@ static int vmap_page_range_noflush(unsigned long
start, unsigned long end,
next = pgd_addr_end(addr, end);
err = vmap_pud_range(pgd, addr, next, prot, pages, &nr);
if (err)
- break;
+ return err;
} while (pgd++, addr = next, addr != end);
- if (unlikely(err))
- return err;
return nr;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists