linux-kernel - Re: [rfc][patch 4/4] fs: tmpfs, ext2 use new truncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090708111420.GB20924@duck.suse.cz>
Date:	Wed, 8 Jul 2009 13:14:20 +0200
From:	Jan Kara <jack@...e.cz>
To:	Nick Piggin <npiggin@...e.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [rfc][patch 4/4] fs: tmpfs, ext2 use new truncate

On Wed 08-07-09 08:53:27, Nick Piggin wrote:
> On Tue, Jul 07, 2009 at 12:38:29PM -0400, Christoph Hellwig wrote:
> > > @@ -68,7 +70,7 @@ void ext2_delete_inode (struct inode * i
> > >  
> > >  	inode->i_size = 0;
> > >  	if (inode->i_blocks)
> > > -		ext2_truncate (inode);
> > > +		ext2_truncate_blocks(inode, 0);
> > >  	ext2_free_inode (inode);
> > >  
> > >  	return;
> > 
> > > -void ext2_truncate(struct inode *inode)
> > > +static void ext2_truncate_blocks(struct inode *inode, loff_t offset)
> > >  {
> > >  	__le32 *i_data = EXT2_I(inode)->i_data;
> > >  	struct ext2_inode_info *ei = EXT2_I(inode);
> > > @@ -1032,27 +1074,8 @@ void ext2_truncate(struct inode *inode)
> > >  	int n;
> > >  	long iblock;
> > >  	unsigned blocksize;
> > > -
> > > -	if (!(S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
> > > -	    S_ISLNK(inode->i_mode)))
> > > -		return;
> > > -	if (ext2_inode_is_fast_symlink(inode))
> > > -		return;
> > > -	if (IS_APPEND(inode) || IS_IMMUTABLE(inode))
> > > -		return;
> > > -
> > 
> > We can't move this to the caller easily.  ext2_delete_inode gets
> > called for all inodes, but we only want to go on truncating for the
> > limited set that passes this check.
> 
> Hmm, shouldn't they have no ->i_blocks in that case?
  Not necessarily. Inode can have extended attributes set and those can
be stored in a special block which is accounted in i_blocks.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/