[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4A5485AB.2000807@novell.com>
Date: Wed, 08 Jul 2009 07:40:27 -0400
From: Gregory Haskins <ghaskins@...ell.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
CC: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, avi@...hat.com
Subject: Re: [KVM PATCH v9 1/2] KVM: make io_bus interface more robust
Michael S. Tsirkin wrote:
> On Tue, Jul 07, 2009 at 01:26:11PM -0400, Gregory Haskins wrote:
>
>
>> I suppose its personal preference either way, so I guess unless Avi
>> objects lets just each have our own style in that regard.
>>
>
> I think Avi already said we don't need to standardize everything.
> I hope at least some of the comments were helpful.
>
>
Yes, it was very helpful and I really *do* appreciate the time you take
to review the code. I think you will see that aside from the things we
agree are whitespace style, I addressed your feedback in v10. The one
notable omission (and this was not intentional) was that I forgot to
document the return value like you requested. If a v11 is needed after
review comments, I will update it then. Otherwise, Ill just submit a
trivial doc patch after v10 is accepted.
Thanks again, Michael,
-Greg
Download attachment "signature.asc" of type "application/pgp-signature" (267 bytes)
Powered by blists - more mailing lists